Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 support #2379

Closed
heddn opened this issue Aug 5, 2022 · 6 comments
Closed

PHP 8.2 support #2379

heddn opened this issue Aug 5, 2022 · 6 comments

Comments

@heddn
Copy link

heddn commented Aug 5, 2022

Platform

( ) MacOS
( x) Linux
( ) Winderz

Installed Via

( ) Homebrew
( ) Apt Package
( X) Manually

PHP Version

( ) 7.4x
( ) 8.0
( ) 8.1
(x) 8.2

Command Executed

Installing terminus, then installing secrets and rsync plugin fall on their face:

Deprecated: Creation of dynamic property Consolidation\AnnotatedCommand\Parser\Internal\BespokeDocBlockParser::$commandInfo is deprecated in phar:///var/www/html/terminus/vendor/consolidation/annotated-command/src/Parser/Internal/BespokeDocBlockParser.php on line 35

Deprecated: Creation of dynamic property Consolidation\AnnotatedCommand\Parser\Internal\BespokeDocBlockParser::$reflection is deprecated in phar:///var/www/html/terminus/vendor/consolidation/annotated-command/src/Parser/Internal/BespokeDocBlockParser.php on line 36
  curl -L https://github.com/pantheon-systems/terminus/releases/download/3.0.7/terminus.phar --output terminus\
  && chmod 755 terminus \
  && ./terminus self-update \
  && mv terminus /usr/local/bin/terminus \
  && terminus self:plugin:install terminus-secrets-plugin \
  && terminus self:plugin:install terminus-rsync-plugin

Expected behavior

I'm trying to get terminus to install on PHP 8.2, which just went beta2RC01 recently.

Actual behavior

If your issue is with a command not working, please run the command again with the -vvv option (--debug in 0.x) and copy everything from the command down to the next prompt and paste it here between a pair of ``` marks.

@heddn
Copy link
Author

heddn commented Sep 13, 2022

It looks like this might be resolved upstream now and we just need to pull in a newer version: consolidation/annotated-command#271

@scottbuscemi
Copy link

Thanks @heddn -- this is on our radar with the upcoming PHP 8.2 release!

@YesCT
Copy link

YesCT commented Dec 29, 2022

I ran into this today after updating Mac OS and Xcode.

$ terminus

PHP 8.2+ is not supported by this version of Terminus.
Check for new versions at https://github.com/pantheon-systems/terminus/releases

Set environment variable TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP to try continuing anyway.
Stopping.

$ which terminus
/opt/homebrew/bin/terminus
$ brew upgrade terminus
Warning: pantheon-systems/external/terminus 3.1.1 already installed
$ php --version
PHP 8.2.0 (cli) (built: Dec  9 2022 16:30:32) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.0, Copyright (c) Zend Technologies
    with Zend OPcache v8.2.0, Copyright (c), by Zend Technologies
$ which php
/opt/homebrew/bin/php

@greg-1-anderson
Copy link
Member

n.b. we have #2414, but we still need to make a release.

@G-Rath
Copy link
Contributor

G-Rath commented Feb 9, 2023

It looks like #2414 was released in 3.1.2, so I think this can be closed now

@CdrMarks
Copy link
Contributor

CdrMarks commented Feb 9, 2023

Thanks for the reminder @G-Rath. #2414 was included in 3.1.1...3.1.2.

@CdrMarks CdrMarks closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants