terminus site deploy fails with "Undefined property: stdClass::$body"

[bwood]

A ticket of the same name (#148) is closed, but I'd like to gingerly and respectfully suggest that this problem should be addressed. Perhaps the author of #148 was suggesting that this issue belongs in a non-terminus issue queue (i.e. it's an issue at the API level)? I would like to suggest that terminus should at the very least 1) indicate to the user whether the deploy succeeded or failed and 2) suppress repeating php errors.

I'm attempting to further automate our Drupal update scripts and conditions like this one are difficult to handle.

bwood@mbp bin$ terminus cli version
Terminus version: 0.5.5
Terminus script: terminus

terminus site deploy --site=websolutions-ob --from=test --env=live --cc --updatedb --note="istdrupal-updates-apply.php"

Notice: Undefined property: stdClass::$body in phar:///Users/bwood/bin/terminus-055/php/class-terminus-command.php on line 258

Call Stack:
    0.0015     226752   1. {main}() /Users/bwood/bin/terminus-055:0
    0.0126     844440   2. include('phar:///Users/bwood/bin/terminus-055/php/boot-phar.php') /Users/bwood/bin/terminus-055:4
    0.0127     857752   3. include('phar:///Users/bwood/bin/terminus-055/php/terminus.php') phar:///Users/bwood/bin/terminus-055/php/boot-phar.php:5
    0.0169    1683536   4. Terminus\Runner->run() phar:///Users/bwood/bin/terminus-055/php/terminus.php:37
    0.0226    2282872   5. Terminus\Runner->_run_command() phar:///Users/bwood/bin/terminus-055/php/Terminus/Runner.php:155
    0.0226    2282936   6. Terminus\Runner->run_command() phar:///Users/bwood/bin/terminus-055/php/Terminus/Runner.php:75
    0.0226    2284456   7. Terminus\Dispatcher\Subcommand->invoke() phar:///Users/bwood/bin/terminus-055/php/Terminus/Runner.php:68
    0.0234    2345344   8. call_user_func() phar:///Users/bwood/bin/terminus-055/php/Terminus/Dispatcher/Subcommand.php:227
    0.0234    2345376   9. Terminus\Dispatcher\CommandFactory::Terminus\Dispatcher\{closure}() phar:///Users/bwood/bin/terminus-055/php/Terminus/Dispatcher/Subcommand.php:227
    0.0236    2367752  10. call_user_func() phar:///Users/bwood/bin/terminus-055/php/Terminus/Dispatcher/CommandFactory.php:35
    0.0236    2367784  11. Site_Command->deploy() phar:///Users/bwood/bin/terminus-055/php/Terminus/Dispatcher/CommandFactory.php:35
    3.3361    7134144  12. Terminus_Command->waitOnWorkflow()
    phar:///Users/bwood/bin/terminus-055/php/commands/site.php:718

(error repeats about 30x)

[bensheldon]

I completely sympathize with the annoyance of failing API requests dumping context-less stack-traces. My initial assumption here is that the deploy workflow is polling for status and for some reason it is erroring out in the API. We should be trapping those API errors and returning something human-readable and debuggable.

[TeslaDethray]

The thing causing this error to appear was fixed last month, but the fact that it would spit out this long, ugly error message was fixed in #477.