-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FONTFILE is compared to a header? #54
Comments
How can HAVE_UI not depend on the presence of a font? Without text, the UI is useless. Besides, it is a gnu/make variable (without override keyword) you can just run Likewise https://github.com/pantherb/setBfree/blob/master/common.mak#L6 is just a default. You should override it at compile time The second case is for the LV2 plugin. A plugin must always be self-contained and never depend on any external files (the official binaries are statically linked, for that reason, too). The font is embedded in the binary via a generated header file Using I hope that clears things up. |
What is the correct way to build both LV2 plugins and the UI app, in other words, everything? (assuming I have the font available.) |
I just run Most packagers just do a For distributable binaries ( http://x42-plugins.com/x42/setBfree ) I use
|
I assume above answered the question |
In this line:
https://github.com/pantherb/setBfree/blob/master/common.mak#L6
you set it to some pre-existing file.
In this line:
https://github.com/pantherb/setBfree/blob/master/common.mak#L120
you compare in to some header file name "verabd.h".
IMO, both lines are wrong. You should install this font under$(PREFIX)$ (DATADIR) and not look for preinstalled fonts.
HAVE_US should be based on user choice, not on presence of some font.
The text was updated successfully, but these errors were encountered: