Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why field SourceConnectionPoint is internal? #42

Closed
freekspb opened this issue Nov 5, 2015 · 3 comments
Closed

Why field SourceConnectionPoint is internal? #42

freekspb opened this issue Nov 5, 2015 · 3 comments

Comments

@freekspb
Copy link

freekspb commented Nov 5, 2015

Class EdgeControlBase has fields:
internal Point? SourceConnectionPoint;
internal Point? TargetConnectionPoint;

Why this fields is internal? I think they will be internal protected, because
I inherited class EdgeControl and override method PrepareEdgePath. In my class I can't set value to SourceConnectionPoint and TargetConnectionPoint. But method UpdatePosition of EdgeLabelControl uses value of SourceConnectionPoint and TargetConnectionPoint. But i don't want override UpdatePosition.

@panthernet
Copy link
Owner

Hi, thanks for feedback. I'll check it.

@panthernet
Copy link
Owner

Sure, this is not logical so i've updated these properties to be protected internal. Haven't got a chance yet to work with derived controls so all these stuff is polished on requests like yours. Thanks!

PS: If you'll find more stuff like that just let me know

@freekspb
Copy link
Author

freekspb commented Nov 5, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants