Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all issues with capture #131

Open
Tracked by #5
Spone opened this issue Feb 2, 2023 · 2 comments
Open
Tracked by #5

Fix all issues with capture #131

Spone opened this issue Feb 2, 2023 · 2 comments
Assignees
@nicolas-brousse
Milestone
v1.0

Comments

@Spone
Copy link
Collaborator

Spone commented Feb 2, 2023 •
edited

This will probably be solved by ViewComponent/view_component#1650
@Spone Spone mentioned this issue Feb 2, 2023
Open
25 tasks
@Spone Spone changed the title fix all issues with capture (helpers using blocks) Fix all issues with capture Feb 2, 2023
@Spone Spone added this to the v1.0 milestone Feb 2, 2023
@Spone
Copy link
Collaborator Author

Spone commented Feb 20, 2023 •
edited

Now that ViewComponent/view_component#1650 is merged, should we just mention in the docs that the capture_compatibility_patch_enabled option has to be enabled?

@nicolas-brousse
Copy link
Member

@Spone I do think so. Maybe we should also activate it in tests too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolas-brousse nicolas-brousse

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@Spone @nicolas-brousse