Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Lambdex should reduce its dependence on PEX APIs #5

Closed
jsirois opened this issue Mar 26, 2019 · 0 comments · Fixed by #7
Closed

Lambdex should reduce its dependence on PEX APIs #5

jsirois opened this issue Mar 26, 2019 · 0 comments · Fixed by #7

Comments

@jsirois
Copy link
Member

jsirois commented Mar 26, 2019

Namely here with pex's is_compressed:
https://github.com/wickman/lambdex/blob/e7ac9582c71c4ba8e15a723d06f28c678fa8762f/lambdex/resources/lambdex_handler.py#L32-L38

We should just test zipfile.is_zipfile(__entry_point__) ourselves.

jsirois added a commit to jsirois/lambdex that referenced this issue Mar 26, 2019
jsirois added a commit to jsirois/pex that referenced this issue Mar 26, 2019
This was eliminated in pex-tool#680 since it was (locally) unused but it turns
out it was used over in lambdex. The long term fix allowing safe
removal of the API is tracked by:
pex-tool/lambdex#5.

Fixes pex-tool#684
jsirois added a commit to jsirois/pex that referenced this issue Mar 26, 2019
This was eliminated in pex-tool#680 since it was (locally) unused but it turns
out it was used over in lambdex. The long term fix allowing safe
removal of the API is tracked by:
pex-tool/lambdex#5.

Fixes pex-tool#684
jsirois added a commit to pex-tool/pex that referenced this issue Mar 26, 2019
This was eliminated in #680 since it was (locally) unused but it turns
out it was used over in lambdex. The long term fix allowing safe
removal of the API is tracked by:
pex-tool/lambdex#5.

Fixes #684
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant