Path filter for PythonInterpreter.iter_candidates. #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
commented
Sep 27, 2020
| with temporary_dir() as bin_dir: | ||
| os.symlink(test_interpreter2, os.path.join(bin_dir, "jake")) | ||
|
|
||
| # Verify path filtering happens before interpreter resolution, which os.path.realpaths |
There was a problem hiding this comment.
This is the use-case coming in a follow-up PR to close #1043. The PEX runtime needs to be able to filter by basename when PEX_PYTHON=python2 (for example) is in the environment. Today this is handled with dedicated code in pex_bootstrapper.py that is a near duplicate of the relevant code in PythonInterpreter.iter_candidates.
Eric-Arellano
approved these changes
Sep 27, 2020
Comment on lines
+36
to
+37
| InterpreterIdentificationJobError = Tuple[str, Union[Job.Error, Exception]] | ||
| InterpreterOrJobError = Union["PythonInterpreter", InterpreterIdentificationJobError] |
There was a problem hiding this comment.
Excellent. Thank you.
This adds support for a path filter to allow unification of Pex buildtime and runtime interpreter discovery. The PythonInterpreter public API family of `iter`, `iter_candidates` and `all` is type-annotated and tests are added for `iter_candidates`. To support proper annotation of iter_candidates helpers, `@overload` support is added for Python 2.7. Work towards pex-tool#1043
jsirois
force-pushed
the
issues/1043/path_filter_prework
branch
from
5e50741
to
5ad317e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a path filter to allow unification of Pex
buildtime and runtime interpreter discovery. The PythonInterpreter
public API family of
iter,iter_candidatesandallistype-annotated and tests are added for
iter_candidates. To supportproper annotation of iter_candidates helpers,
@overloadsupport isadded for Python 2.7.
Work towards #1043