Ensure PEX files aren't symlinked in venv. #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure PEX file contents are materialized in venvs as durable files. Previously, distributions were handled correctly but PEX sources and resources were not. A test is added that exercised the bug but is now fixed. Fixes pex-tool#1239
jsirois
commented
Feb 18, 2021
| ) | ||
| venv_pex = os.path.join(venv, "pex") | ||
| shutil.rmtree(src) | ||
| assert 42 == subprocess.Popen(args=[venv_pex]).wait() |
There was a problem hiding this comment.
This was the failing line prior to the fix. The main module was not found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure PEX file contents are materialized in venvs as durable files.
Previously, distributions were handled correctly but PEX sources and
resources were not. A test is added that exercised the bug but is now
fixed.
Fixes #1239