Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pex venv script handles entrypoints like PEX. #1242

Merged
merged 1 commit into from Feb 19, 2021

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Feb 19, 2021

Previously behavior diverged for entrypoint functions returning a value.
Now both PEXes and the pex venv script behave the same and the
behavior is documented and tested.

Fixes #1241

Previously behavior diverged for entrypoint functions returning a value.
Now both PEXes and the `pex` venv script behave the same and the
behavior is documented and tested.

Fixes pex-tool#1241
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this sounds good.

@jsirois jsirois merged commit ec04a58 into pex-tool:master Feb 19, 2021
@jsirois jsirois deleted the issues/1241 branch February 19, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The venv pex script handles entrypoint functions differently from PEX.
2 participants