Fix --runtime-pex-root leak in pex bootstrap.
#1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PEX bootstrap involved finding an interpreter, the `--runtime-pex-root` was not propagated and interpreter identification files would leak into the default `PEX_ROOT`. Add a failing test that is fixed by proper PEX_ROOT propagation during PEX bootstrapping.
|
After the weekend bump. |
Eric-Arellano
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PEX bootstrap involved finding an interpreter, the
--runtime-pex-rootwas not propagated and interpreter identificationfiles would leak into the default
PEX_ROOT.Add a failing test that is fixed by proper PEX_ROOT propagation during
PEX bootstrapping.