Improve resolve error information. #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is motivated by making a hard to debug macOS / CI specific issue here: https://github.com/pantsbuild/pants/pull/11773/checks?check_run_id=2162600254#step:9:87 easier to debug. |
When a resolve failed at the stage of determining roots it left alot of context on the floor. Add that context in the error message when available.
jsirois
force-pushed
the
_root_requirements_iter/better_error_message
branch
from
dd9c72d
to
c282d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a resolve failed at the stage of determining roots it left alot
of context on the floor. Add that context in the error message when
available.