Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --platform resolves for current interpreter. #1364

Merged
merged 1 commit into from Jun 19, 2021

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Jun 19, 2021

Previously, if a --platform resolve was being executed with an
interpreter that matched the platform, a regular full-featured
interpreter resolve was performed. This prevented, for example,
resolving using a CPython 3.8 interpreter on a manylinux2014 capable
host for deployment to a host that is only manylinux2010 capable. The
--resolve-local-platforms option exists to force this sort of
fallback to a full-featured interpreter resolve when that is desired.

Fixes #1355

Previously, if a `--platform` resolve was being executed with an
interpreter that matched the platform, a regular full-featured
interpreter resolve was performed. This prevented, for example,
resolving using a CPython 3.8 interpreter on a manylinux2014 capable
host for deployment to a host that is only manylinux2010 capable. The
`--resolve-local-platforms` option exists to force this sort of
fallback to a full-featured interpreter resolve when that is desired.

Fixes pex-tool#1355
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks

@jsirois jsirois merged commit aec71b8 into pex-tool:main Jun 19, 2021
@jsirois jsirois deleted the issues/1355 branch June 19, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using --platform manylinux2010 includes pyarrow wheel for manylinux2014
2 participants