Switch vendoring from pip install ... to Pex install.
#2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kill unused interpreter parameter and fixup comment to reflect new use of pep_427. Fix vendoing finalization excludes to handle bytecode.
huonw
approved these changes
Dec 17, 2023
| installed_files.append( | ||
| InstalledWheel.create_installed_file(path=requested_path, dest_dir=dest) | ||
| ) | ||
| if interpreter: |
There was a problem hiding this comment.
Why the change from unconditional to conditional for these files?
There was a problem hiding this comment.
REQUESTED is not required at all; see: https://peps.python.org/pep-0376/#one-dist-info-directory-per-installed-distribution.
RECORD is required to support uninstalling as noted; so we still include it when an interpreter is supplied (installing in a venv) for interoperability with external tools like pip uninstall, but not for installed wheel chroots since those are private and never uninstalled by anyone but Pex, and, since they are chroots, this can be done with a simple recursive chroot dir remove.
So, basically, this just saves a small amount of work for the most common Pex wheel install case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pex now only uses Pip for resolving distributions (
pip download ...)and building wheels (
pip wheel ...), installation of wheels in chrootsand venvs is now completely handled by Pex everywhere in the code base.