Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import sorting. #712

Merged
merged 1 commit into from Apr 21, 2019
Merged

Fix import sorting. #712

merged 1 commit into from Apr 21, 2019

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Apr 21, 2019

Mechanically generated using tox -eisort-run,style. I'm not sure how
this got past CI.

@jsirois
Fix import sorting.
8069581 
Mechanically generated using `tox -eisort-run,style`. I'm not sure how
this got past CI.
Eric-Arellano
Eric-Arellano approved these changes Apr 21, 2019
View reviewed changes
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you notice this was wrong to begin with?

@jsirois
Copy link
Member Author

jsirois commented Apr 21, 2019

How did you notice this was wrong to begin with?

I run tox -eisort-run,style habitually before committing. That turned up edits to a file I wasn't editing.

@jsirois jsirois merged commit 9363450 into pex-tool:master Apr 21, 2019
@jsirois jsirois deleted the isort/fix branch April 21, 2019 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsirois @Eric-Arellano