Fix #794 issue by add missing return statement in __str__ #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jsirois if this PR could be embedded into a fix release that would be great ! It's blocking my team and teammates 👍 |
jsirois
approved these changes
Nov 18, 2019
|
Thanks a lot ! |
|
Hello @jsirois is the 2.0.1 release still scheduled for today ? |
|
Yes. |
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Nov 20, 2019
Previously rendering was broken but fixed in pex-tool#795. Add a test of that fix.
jsirois
added a commit
that referenced
this pull request
Nov 20, 2019
Previously rendering was broken but fixed in #795. Add a test of that fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #794, every build failed using --index-url option