Implicitly trust explicitly requested repos. #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we did not do this and could thus confusingly fail resolves against explicitly requested insecure repos. Fixes pex-tool#812
Eric-Arellano
approved these changes
Nov 26, 2019
Comment on lines
+54
to
+57
| if 'http' == url_info.scheme: | ||
| # Implicitly trust explicitly asked for http indexes and find_links repos instead of requiring | ||
| # seperate trust configuration. | ||
| trusted_hosts.append(url_info.netloc) |
There was a problem hiding this comment.
Do you think we should log when this happens? I'm not sure what -v level that would be, but maybe something people should know about and encourage them to see if there's an https version.
There was a problem hiding this comment.
In order for this to happen, they said something like pex --index=http://my.index .... If they really mean to use the insecure index - say its internal - they probably would appreciate not being nagged. I think we'd need to support some way of saying "no, really, trust me" in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we did not do this and could thus confusingly fail resolves
against explicitly requested insecure repos.
Fixes #812