Convert bdist_pex tests to explicit cmdclass.
#897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the test relied upon the tox venv interpreter, which implicitly builds and installs the pex wheel, being the interpreter that executed the `python setup.py bdist_pex ...` command. This assumption could be foiled when running under `pyenv` which OSX CI shards do. Instead, explicitly add pex to the `PYTHONPATH` of the interpreter and let distutils know about `bdist_pex` via `--command-packages`.
Eric-Arellano
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the test relied upon the tox venv interpreter (which
implicitly builds and installs the pex wheel) being the interpreter that
executed the
python setup.py bdist_pex ...command. This assumptioncould be violated when running under
pyenvwhich OSX CI shards do.Instead, explicitly add pex to the
PYTHONPATHof the interpreter andlet distutils know about
bdist_pexvia--command-packages.Fixes #896