Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: you just clobbered the 'jose' that was on npm before #47

Closed
davidjludwig opened this issue Oct 2, 2019 · 1 comment
Closed

bug: you just clobbered the 'jose' that was on npm before #47

davidjludwig opened this issue Oct 2, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@davidjludwig
Copy link

require('jose') used to return this: https://github.com/autoit4you/node-jose#readme

!!!!

this is a breaking change for anyone who was using require('jose') and getting https://github.com/autoit4you/node-jose#readme

@davidjludwig davidjludwig added the bug Something isn't working label Oct 2, 2019
@panva
Copy link
Owner

panva commented Oct 3, 2019

this is a breaking change

In the sense that an existing system depending on the old package codebase would be affected? It really isn’t. The old jose, which i had the permission for from the owner of was unmaintained and unsupported, with barely 50 downloads per week, was version 0.3.x.

That semver range is not affected and is still available (npm i jose@0.3) for those who use it and declare in their package.json or lock files.

I have consulted this move both with the author and npmjs organization support and it is nothing more than a major package version bump under semantic versioning.

@panva panva closed this as completed Oct 3, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants