Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudflare Workers use can still hang #509

Closed
2 tasks done
tv42 opened this issue Mar 2, 2023 · 1 comment
Closed
2 tasks done

Cloudflare Workers use can still hang #509

tv42 opened this issue Mar 2, 2023 · 1 comment

Comments

@tv42
Copy link

tv42 commented Mar 2, 2023

What happened?

FYI I just got confirmation that the worry from #355 (comment) is real: https://news.ycombinator.com/item?id=34989560#34991060

This means that on Cloudflare Workers, with some bad luck and a request getting canceled due to taking too long/client closing connection/etc, the isDone loop can hang forever.

Version

e44cd18

Runtime

Cloudflare Workers

Runtime Details

n/a

Code to reproduce

Sorry.

Required

  • I have searched the issues tracker and discussions for similar topics and couldn't find anything related.
  • I agree to follow this project's Code of Conduct
@tv42 tv42 added the triage label Mar 2, 2023
@panva
Copy link
Owner

panva commented Mar 2, 2023 •
edited

I've reached out to Erwin and Kenton to get a better grip at this, in the meantime, i've disabled this single flight pattern for CF workers runtimes.

@panva panva removed the triage label Mar 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panva @tv42