Feature: allow arrow-function & class-methods as adapter factory #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
like |
talentumtuum
force-pushed
the
feature/arrow-function-and-class-method-adapters
branch
from
2c474d3
to
b863eb3
Compare
talentumtuum
force-pushed
the
feature/arrow-function-and-class-method-adapters
branch
from
b863eb3
to
4ac29be
Compare
|
@panva Ready for review |
|
@talentumtuum the code may pass initialization but static class function or arrow function factory functions don't actually work, i've added tests for such. |
|
@panva I'll take care of this problem in my spare time, I think I'll be back with a solution in 1-3 days, maybe today. Okay? |
|
Thank you, for sure, come back to the problem any time. FWIW it might be as simple as updating Edit: and |
|
@panva Thank you for your quick assistance |
|
Thank you for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Now when implementing the "AdapterFactory" type from the package https://www.npmjs.com/package/@types/oidc-provider
a situation can happen where the types are correct, but at runtime we get an error.
I found a mention of this problem here #776 (comment)
With this PR I add the ability to use arrow-functions and class methods as a factory and at the same time fix the non-obvious behavior when writing code in typescript