Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent redefinition of claims within tokenset #511

Closed

Conversation

fredericoo
Copy link

@fredericoo fredericoo commented Jul 25, 2022

Fixes a problem in which if values contained the property claims, it would replace the claims function.

Discovered when trying to call claims() on next-auth via this line.

Checklist

✅ I've added tests to replicate the behaviour automatically

@panva
Copy link
Owner

panva commented Aug 16, 2022

Since there is no defined claims response parameter on the token, or authorization endpoints I don't agree with this PR's fix.

The solution needs to be ignore all unrecognized properties or throw them all in a single bag of "unrecognized", or something to that effect.

I'll ponder some more on this.

@panva panva closed this Aug 16, 2022
panva added a commit that referenced this pull request Aug 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants