Allow empty strings in response #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
requested changes
Jun 16, 2022
|
Thank you @blakeembrey |
|
@blakeembrey do you need this released? Are you okay waiting out an answer from GitHub (wrt #16)? |
|
Happy to wait 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub allows for an empty scope string to request public user information: https://docs.github.com/en/developers/apps/building-oauth-apps/scopes-for-oauth-apps#available-scopes. Alternatively I could add an
ignoreScopesoption like the other "ignore" flags but that looks like it'll get overwhelming quickly. Happy to modify it as needed.Edit: Alternatively it could also be a
skipsymbol. Let me know if either of these work for you and I can update the PR.