Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probable starting pitcher #11

Closed
FlowFX opened this issue Jun 28, 2016 · 5 comments
Closed

Probable starting pitcher #11

FlowFX opened this issue Jun 28, 2016 · 5 comments
Labels

Comments

@FlowFX
Copy link

FlowFX commented Jun 28, 2016

This project is awesome. Thank you so much!

Is there a way to find the probable starting pitcher for today's games? They are displayed on mlb gameday.

@panzarino
Copy link
Owner

panzarino commented Jun 28, 2016

I'm not sure right now, but I will look into it and get back to you soon.

Edit: I have found the data that contains the probable pitcher, but I have not implemented it into mlbgame yet. I will add it sometime soon along with other features.

@panzarino
Copy link
Owner

After looking into it a little more, the file changes too much during the game and after the game so it can't be used in mlbgame. If you want to get this data on your own, it is available in linescore.xml for a game that has not been played yet.

Here is an example (just change the date and game id to match):
http://gd2.mlb.com/components/game/mlb/year_2016/month_06/day_30/gid_2016_06_30_lanmlb_milmlb_1/linescore.xml

Alternatively, if you find a good solution for getting this data and submit it in a PR, I would be happy to merge it.

@panzarino panzarino changed the title Starting pitcher Probable starting pitcher Jun 28, 2016
@FlowFX
Copy link
Author

FlowFX commented Jun 28, 2016

Thanks for the info! linescore.xml looks good. Probable starting pitcher is really only useful before the game starts. No need to put it into the mlbgame data. I'll have a PR for you, eventually. But it will take a while before I get to that part of my project.

For past games the starting pitcher is always the first pitcher in the pitching stats for that game, correct?

@panzarino
Copy link
Owner

Yes, they are in order of which they appeared in the game so the starter is first.

@FlowFX
Copy link
Author

FlowFX commented Apr 20, 2017

I just saw that the probable starting pitchers are now available. Thank you!! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants