Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with getting teams and differentiation #16

Closed
zenverak opened this issue Oct 31, 2016 · 6 comments
Closed

Issues with getting teams and differentiation #16

zenverak opened this issue Oct 31, 2016 · 6 comments

Comments

@zenverak
Copy link

So far this is excellent but I don't see an easy way to do a few things

  1. Get a list of active teams in the league. Something like teams = mlbgame.teams
  2. Differentiate between regular season and preseason games without specifying exact dates. Right now all game.game_type show is 'go_game' . This may be an issue with the source data.

Is this something I am missing?

@panzarino
Copy link
Owner

panzarino commented Oct 31, 2016

  1. I am not sure that I can dynamically update that from mlb.com, but I can try to see if there is a way to implement all the teams as a list
  2. If the games show up as go_game, that is the game_type information that I receive from mlb.com. I am currently refactoring the game code and seeing if there is extra information that I can pull from mlb.com

I have been meaning to update the library for a while and now that I have more time I will include these suggestions in coming improvements.

@panzarino
Copy link
Owner

Update: It looks like I am able to get team data from mlb.com and I will work on implementing that into the api: http://mlb.mlb.com/properties/mlb_properties.xml

@zenverak
Copy link
Author

Thanks man. I greatly appreciate it. So far I am enjoying using it as its extremely similar to nflgame so once I get the data in the format I want, I can use my existing code.

@panzarino
Copy link
Owner

Awesome, I designed this library after nflgame, which I had used in one of my own projects.

@zenverak
Copy link
Author

Yeah, thats one of the main things I noticed. In the end I am trying to find something like this for all of the sports so that I can get the data into a form I want so that I can do some 'analysis' on it. Right now its not anything statistical, but once I get more sports in I think I'll try and branch it into something that has some 'prediction power'.

@panzarino
Copy link
Owner

I have added this functionality in the dev branch. Feel free to clone that and test it out. This functionality will officially be released in the next release (probably 2.3.0) which will be coming out very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants