Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sign_with_time part of the S3Action trait #27

Closed
paolobarbolini opened this issue Oct 9, 2021 · 1 comment
Closed

Make sign_with_time part of the S3Action trait #27

paolobarbolini opened this issue Oct 9, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@paolobarbolini
Copy link
Owner

All structs that implement S3Action currently have a sign_with_time method which takes the time at which the URL should be signed at. We use that method for tests. This proposes to move that method to the S3Action trait.
@paolobarbolini paolobarbolini added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 9, 2021
@z4f1r0v z4f1r0v mentioned this issue Oct 12, 2021
Merged
@paolobarbolini
Copy link
Owner Author

Closed by #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paolobarbolini