Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss cards cause black screen on iOS13 and Xcode 11.2 #134

Closed
Rida-ba opened this issue Dec 6, 2019 · 1 comment
Closed

Dismiss cards cause black screen on iOS13 and Xcode 11.2 #134

Rida-ba opened this issue Dec 6, 2019 · 1 comment

Comments

@Rida-ba
Copy link

Rida-ba commented Dec 6, 2019

First, I want to thank you for your work. It's awesome feature but
I'm sorry to let you know that it's not working anymore on iOS13 and Xcode 11.2.
Maybe I'm the only one but I prefer to tell you.

As we can see on this following screen :

I don't know if this is an animation issue but if you have a clue, I will be grateful.

Thanks in advance for your help.

Rida.

@Rida-ba
Copy link
Author

Rida-ba commented Dec 6, 2019

Don't worry, I resolve this issue by myself. It's known problem in iOS 13 because
Apple change their view presentation style. So starting from now we have to add this following line into Cards.swift :

detailVC.modalPresentationStyle = .fullScreen

Specially when you initialize DetailViewController in open func initialize().

I hope you can fix it with my advice in the next release.

@Rida-ba Rida-ba closed this as completed Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant