Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silenced failures on yaml parsing with an empty changeset #1432

Closed
brymacto opened this issue Jul 25, 2023 · 2 comments
Closed

Silenced failures on yaml parsing with an empty changeset #1432

brymacto opened this issue Jul 25, 2023 · 2 comments
Labels

Comments

@brymacto
Copy link

::Kernel.warn format(E_YAML_PERMITTED_CLASSES, e)

When a yaml parsing error is encountered, an empty object changes object is returned with a warning logged.

Is it not better to fail fast here and let an exception surface? The empty object is misleading and difficult to debug.

If there's openness to such a change, I could open a PR.

@gurgelrenan
Copy link
Member

@brymacto Could you reproduce this issue following this guide? https://github.com/paper-trail-gem/paper_trail/blob/master/.github/ISSUE_TEMPLATE/bug-report.md

@github-actions
Copy link

This issue has been automatically marked as stale due to inactivity.
The resources of our volunteers are limited.
Bug reports must provide a script that reproduces the bug, using our template. Feature suggestions must include a promise to build the feature yourself.
Thank you for all your contributions.

@github-actions github-actions bot added the Stale label Oct 29, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants