Fixed: merge newly added colors into global styles #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18
When there are multiple customizable widgets on the same page that contain colors in their style definitions, they are loaded asynchronously and overwrite the colors saved in the global styles. This way, a race condition is produced, each widget overriding the other widgets' changes to the global styles and, at the end, there colors added are just from one of the widgets.
Widget1 introduces color1: after updating the styles, the list of colors contains color1.
Widget2 introduces color2: when updating the styles, the old styles (that are being currently updated) do not contain color1; after the update, global styles will only contain color2.