Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transferred content has quotation-marks and apostrophes removed. #43

Closed
Bergene opened this issue Jun 7, 2021 · 8 comments
Closed

Transferred content has quotation-marks and apostrophes removed. #43

Bergene opened this issue Jun 7, 2021 · 8 comments
Assignees

Comments

@Bergene
Copy link

Bergene commented Jun 7, 2021

Hi.

I just updated kindle2notion from 0.1.2 to 0.1.7.

I took a backup of all my Clippings in Notion, deleted the original pages and transferred the content from 'My Clippings.txt' to a fresh Notion database.

Now all quotation-marks and apostrophes are missing when displayed in Notion. Now all the lines just kind of blend in with another, I am not able to separate what is thought, description or quotes.

The quotation-marks and apostrophes are still present in 'My Clippings.txt' and even in my backup Clippings Notion Database (used kindle2notion 0.1.2, so I know that this was working before).

@paperboi
Copy link
Owner

paperboi commented Jun 7, 2021

That's odd, hadn't noticed that before. My Clippings file doesn't contain quotation marks between each clipping. Will add em manually for each highlight and ignore for notes in the next commit.

@Bergene
Copy link
Author

Bergene commented Jun 8, 2021

It was a new issue for me when updating to 0.1.7, previously I have not experienced this.

The comment/note/highlights should look like this:
“I’m no highspren,” the captain spat. “I can see that the variety of humankind is what gives you strength. Your ability to change your minds, to go against what you once thought, can be a great advantage. But your bond is dangerous, without Honor. There will not be enough checks upon your power—you risk disaster.”

But when the transfer to Notion is complete the same comment/note/highlight looks like this:
Im no highspren, the captain spat. I can see that the variety of humankind is what gives you strength. Your ability to change your minds, to go against what you once thought, can be a great advantage. But your bond is dangerous, without Honor. There will not be enough checks upon your poweryou risk disaster.

This can be an issue when trying to decipher if it's a quote from a person or just commentary.

@Bergene
Copy link
Author

Bergene commented Jun 16, 2021

For now I have reverted back to version 0.1.2 as the quotes and apostrophes are untouched in this version.

@paperboi paperboi self-assigned this Jun 25, 2021
@paperboi
Copy link
Owner

Hi @Bergene! This issue is addressed in the latest release aka kindle2notion 0.1.8.
Thank you for your patience and hope this clears this particular problem up.

@Bergene
Copy link
Author

Bergene commented Jun 25, 2021

Thank you. I will test ut asap.

@Bergene
Copy link
Author

Bergene commented Jun 30, 2021

Hi @paperboi.
The issue is unfortunately not fixed in 0.1.8. I just tested it and all the quotation marks and apostrophes are removed from the transferred text.

I love the additions of highlighting the notes and such though in the new version.

@abishekmuthian
Copy link

I confirm this issue persists in 0.1.8, Will investigate further during the weekend.

@paperboi
Copy link
Owner

paperboi commented Jul 15, 2022

Hi, fixed this in the latest release, please update and try running it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants