Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests #19

Closed
Fraham opened this issue Nov 3, 2017 · 11 comments
Closed

Unit Tests #19

Fraham opened this issue Nov 3, 2017 · 11 comments

Comments

@Fraham
Copy link
Contributor

Fraham commented Nov 3, 2017

I have just read this blog post: http://tomek.wiszniewski.cc/how-css-unit-tests-helped-us-move-fast/
This goes over how its possible to write unit tests for css, this would be really handy in this project as it will allow us to have our LESS code tested automatically

@rhyneav
Copy link
Member

rhyneav commented Nov 4, 2017

Very neat article, I honestly had no idea there was testing for CSS (but it makes sense). Do you know what other CSS frameworks are using for tests? In addition to tape-css mentioned in the article, there's also quixote for unit testing. Have you used either one of these before?

There's also regression testing, here's a neat article on that.

Overall though, I agree that it would be handy in this project!

@Fraham
Copy link
Contributor Author

Fraham commented Nov 5, 2017

I only have experience of unit and regression testing in C# so i havn't used either of these testing frameworks.

I like the look of quixote, seems to do everything that i would expect it to do.

Made setup a Github project so contributors could pick up tasks of adding unit and regression tests for each component

@rhyneav
Copy link
Member

rhyneav commented Nov 5, 2017

I like quixote as well, looks very intuitive.

A Github project is a good idea. I'll set that up once we have the testing framework put in place. That way there's no friction to adding in more test coverage.

@Fraham
Copy link
Contributor Author

Fraham commented Nov 5, 2017

@rhyneav could you start the testing framework process off so it is all setup and so that the tests run through the continuous integration

I have seen to have created a project for testing, I can't seem to make any new cards or change the status of the cards, might need to open up premissions

@rhyneav
Copy link
Member

rhyneav commented Nov 6, 2017

That sounds good, I'll work on getting quixote set up!

I'll also take a look at permissions for the testing project. It'd be pretty silly if I was the only one that could add/edit those!

@Fraham
Copy link
Contributor Author

Fraham commented Nov 9, 2017

@rhyneav any update on the unit test setup?

@brodybits
Copy link
Contributor

Could this be considered a "help wanted" issue?

@rhyneav
Copy link
Member

rhyneav commented Nov 10, 2017

@Fraham no update, sorry. I've let the ball drop on this one. @brodybits I'll update it to a help wanted issue.

@TotomInc
Copy link
Contributor

Is unit testing on CSS frameworks really useful? That's the real question, is it worth to spend a few hours or even days on this?

@Fraham
Copy link
Contributor Author

Fraham commented Nov 23, 2017

@TotomInc the sort of unit testing I am thinking about is when dealing with less functions and css inheritance.

So it would be nice to have unit tests set up before doing a refactoring as it will prove that the refactor hasn't broken anything.

Also for less functions, I think all logic should be tested to ensure the results are as expected and doesn't regress

@rhyneav
Copy link
Member

rhyneav commented Nov 24, 2017

Some basic tests for colors and flexbox styles might be good. I don't think it's a huge priority, but could be a nice addition as the framework gets larger. And especially if JavaScript gets added to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants