Fix type3 switch component hover effect #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oli8
approved these changes
May 31, 2023
|
@kena0ki Could you rebase/fix conflicts? |
kena0ki
force-pushed
the
feature-type3-switch-hover-effect-fix
branch
from
3bed424
to
5ba4c7d
Compare
|
@Oli8 Thank you for the review! I fixed conflicts. |
Oli8
force-pushed
the
feature-type3-switch-hover-effect-fix
branch
from
5ba4c7d
to
1f2367f
Compare
Oli8
force-pushed
the
feature-type3-switch-hover-effect-fix
branch
from
1f2367f
to
05094e2
Compare
|
@kena0ki Sorry I messed up trying to remove the unnecessary commits 😬 , could you reopen the PR using the changes you should have locally ? |
|
Sorry for inconvenience🥲 I rebased the branch after I merged it once. I think that's the reason why the unnecessary commits were showed up on GitHub. (I thought It's not a problem for the source code though) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Fixed box-shadow and rotate when the switch component is checked and hovered.
...
Developer Certificate of Origin
Sample pictures
Before
https://user-images.githubusercontent.com/29003390/204531980-581d4284-e2f6-44ce-b24c-dbd9fe358b18.mov
After
https://user-images.githubusercontent.com/29003390/204532452-c1cecb35-6f4d-43f0-87be-b015951dda22.mov