Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting #70

Closed
rhyneav opened this issue Nov 23, 2017 · 4 comments
Closed

Linting #70

rhyneav opened this issue Nov 23, 2017 · 4 comments
Assignees
Labels

Comments

@rhyneav
Copy link
Member

rhyneav commented Nov 23, 2017

In addition to adding an .editorconfig (#54), adding a linter like stylelint would be beneficial in keeping contributions well styled.

@MunifTanjim
Copy link
Contributor

Prettier would be a good choice for this.

@rhyneav
Copy link
Member Author

rhyneav commented Nov 24, 2017

Prettier looks great for this, thank you for the link!

@Fraham Fraham added the feature label Dec 3, 2017
@rhyneav rhyneav self-assigned this Dec 7, 2017
@rhyneav
Copy link
Member Author

rhyneav commented Jan 3, 2018

After doing some research, it looks like Prettier is used more to auto format code, whereas a linter like stylelint is better suited for warning about inconsistent code formatting. It's also nice to have the code base now in SCSS as there are a lot more tools in this department than for LESS.

After an initial run with stylelint, it looks like a lot of style tweaks are needed :O

image

Code is currently being worked on in the feature-linter branch. I'll look more into what rules should or not be used, but it should be testable with an npm install and npm run stylelint. After rules have been figured out, then going through and updating the code should be a breeze.

@rhyneav
Copy link
Member Author

rhyneav commented Jun 22, 2018

Added in 1.5.0 :)

@rhyneav rhyneav closed this as completed Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants