Implement theming PapercupStyle(), Flutter 3.0 support and more
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This specific implementation allows for backward compatibility as mentioned here: https://docs.flutter.dev/development/tools/sdk/release-notes/release-notes-3.0.0#your-code. Closes papercups-io#87.
Renaming the widget from `PaperCupsWidget` to `PapercupsWidget` in order to follow to official Papercups spelling.
This change helps us add consistency and avoid potential naming conflicts.
This commit adds support for full theming of the widget. Some breaking changes to PapercupsWidget & PapercupsProps were made in order to collocate related params. The new API is available in the updated README. Fixes papercups-io#18.
aguilaair
reviewed
May 27, 2022
|
Also added some more refactoring for non-nullsafe snippets here and there. |
aguilaair
approved these changes
May 27, 2022
|
I'll do my best to release 3.0 this weekend, thank you so much for all this @CharlesMangwa |
|
Awesome, thanks for the super fast merge once again! 馃檶 And thanks in advance for the v3 but don't worry, no hurry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @aguilaair!
This PR includes a couple of changes listed as follow:
Flutter 3 support
The change made in 1aa6322 fixes the redundant null-aware operators warning introduced in Flutter 3.0, while keeping backwards compatibility for previous Flutter versions.
Full theming support via new
PapercupsStyleEven with the work made for #18, I encountered some visual discrepancies after enabling dark mode in my app via:
That's why I exposed most of the styling params via the new
PapercupsStyleclass. The new API has been detailed in the updated README. Please feel free to double-check I didn't make any mistake there 馃槄.This change also required a breaking change to
PaperCupsWidget&Propsin order to collocate all visual params.Prefix all user-facing classes with
PapercupsIn order to add consistency and avoid potential naming conflicts, I add
Papercupsas a prefix to all the user-facing classes (PapercupsCustomerMetadata,PapercupsProps,PapercupsStyle&PapercupsIntl).In the same spirit, I made another breaking change which was renaming
PaperCupsWidgettoPapercupsWidget, so that it'd follow the official spelling.Update README with missing params
On top of the new
PapercupsStyleand moving some of the oldPapercupsWidget&PapercupsPropsparams around, I also added some existing params that were not documented yet.I hope all these changes make sense to you and can fit in with what you had planned for the upcoming v3.
Let me know if you'd like me to make some changes! 馃檶