Skip to content
This repository has been archived by the owner on Jan 11, 2018. It is now read-only.

Restructure output, add tests #20

Merged
merged 1 commit into from
Dec 9, 2015

Conversation

d3ming
Copy link

@d3ming d3ming commented Dec 9, 2015

Integration test coverage now at 85%!

$ make test-all
------------------------------------------ coverage: platform darwin, python 2.7.10-final-0 -------------------------------------------
Name                    Stmts   Miss  Cover   Missing
-----------------------------------------------------
tagcompare/__init__         0      0   100%
tagcompare/capture         80     19    76%   21-22, 33-34, 49, 70-71, 82-85, 114, 116, 134-139
tagcompare/compare         95     33    65%   27-28, 56, 73-74, 76-77, 82, 110, 113, 119-144, 148-152
tagcompare/image           61      4    93%   21-24, 101
tagcompare/logger          41      0   100%
tagcompare/output         139     19    86%   39, 43, 59, 63, 79, 106, 166, 170-172, 175-177, 180-182, 215, 225-226
tagcompare/placelocal      68     17    75%   28-29, 61-62, 67-69, 73-75, 97, 104-105, 117-121
tagcompare/settings        77      0   100%
tagcompare/webdriver       69      3    96%   52-54
-----------------------------------------------------
TOTAL                     630     95    85%

Unit test coverage now at 62%:

$ make test
------------------------------------------ coverage: platform darwin, python 2.7.10-final-0 -------------------------------------------
Name                    Stmts   Miss  Cover   Missing
-----------------------------------------------------
tagcompare/__init__         0      0   100%
tagcompare/capture         80     68    15%   19-44, 48-52, 68-89, 95-124, 134-139
tagcompare/compare         95     33    65%   27-28, 56, 73-74, 76-77, 82, 110, 113, 119-144, 148-152
tagcompare/image           61     10    84%   21-24, 84-92, 101
tagcompare/logger          41      0   100%
tagcompare/output         139     32    77%   39, 43, 59, 63, 79, 105-117, 143-145, 166, 170-172, 175-177, 180-182, 215, 225-226
tagcompare/placelocal      68     50    26%   17-18, 23-41, 53-75, 94-108, 117-121
tagcompare/settings        77      0   100%
tagcompare/webdriver       69     49    29%   18-21, 29-40, 50-60, 64, 69-81, 85-88, 94-105, 109-113
-----------------------------------------------------
TOTAL                     630    242    62%

@d3ming d3ming force-pushed the restructure-output branch 4 times, most recently from 7d1654a to a2b8b54 Compare December 9, 2015 23:20
- Write to /tmp/tagcompare instead of the working directory of the project
- Restructure output so compare/capture are done under the same jobid. Closes #14
- Support different tag types. Closes #19
- Add more unit and integration tests! Test coverage at 62%/85% respectively
- Many refactors to allow testing, also introduced a global for settings.TEST_MODE
@d3ming d3ming merged commit 923a4a1 into makethunder:master Dec 9, 2015
@d3ming d3ming deleted the restructure-output branch December 9, 2015 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant