Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event delta incorrect in develop branch #983

Closed
tjunnone opened this issue Feb 18, 2016 · 3 comments
Closed

Event delta incorrect in develop branch #983

tjunnone opened this issue Feb 18, 2016 · 3 comments

Comments

@tjunnone
Copy link
Contributor

I've been testing git versions for a while and I've noticed a regression on the develop branch:

In 0.9.25 and in git versions from early January, a mouseup event (inside of a ToolEvent in my case) will have a delta value from the mousedown point measuring how far you've moved.

In current develop branch head, the mouseup delta is very small no matter how far you've moved, delta.length is always somewhere around 0.90 for me. So it seems to me it's probably just using the last two points, not the entire travel delta.

I may do a git bisect to find the exact point of change a bit later.

@lehni
Copy link
Member

lehni commented Feb 19, 2016

Is this still the case now, since my fix for #981 (that I just pushed now, on the road at the moment). I believe it's already fixed.

@tjunnone
Copy link
Contributor Author

Yep, that appears to have fixed it. Thanks!

@lehni
Copy link
Member

lehni commented Feb 19, 2016

Sweet! Two birds, on stone : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants