Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Location Tick Times #31

Open
sofianedjerbi opened this issue Apr 2, 2023 · 1 comment
Open

API: Location Tick Times #31

sofianedjerbi opened this issue Apr 2, 2023 · 1 comment
Labels
status: needs triage type: feature Request for a new Feature.

Comments

@sofianedjerbi
Copy link
Contributor

sofianedjerbi commented Apr 2, 2023

Is your feature request related to a problem?

As a regionised server software, we don't know what current API Bukkit#getTickTimes, Bukkit#getAverageTickTime and Bukkit#getTPS should return.
It might be great to get significative TPS info based on region tick times.

Describe the solution you'd like.

Deprecate Bukkit#getTickTimes and Server#getTickTimes
Deprecate Bukkit#getAverageTickTime and Server#getAverageTickTime
Deprecate Bukkit#getTPS and Server#getTPS
Add Bukkit.getTickTimes(@NotNull Location): Give Tick Times based on Location Region Tick Times

Describe alternatives you've considered.

Bukkit.getTickTimes(@NotNull Entity): Give Tick Times based on Entity Region Tick Times
Same with getTPS getAverageTickTimes.

Other

No response

@sofianedjerbi sofianedjerbi added status: needs triage type: feature Request for a new Feature. labels Apr 2, 2023
@sofianedjerbi sofianedjerbi changed the title API: Entity Tick Times API: Location Tick Times Apr 2, 2023
@Spottedleaf
Copy link
Member

The region at any location is undefined unless owned by the current thread. The region which owns an entity is even less-defined, too. These issues make the suggested APIs generally undefined - how do they play in with things such as region transience?

Basically, need APIs that ones that delay a return value when the region state is considered valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage type: feature Request for a new Feature.
Projects
None yet
Development

No branches or pull requests

2 participants