Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialization option to change limit on workspace symbols #76

Closed
karthiknadig opened this issue Feb 24, 2021 · 3 comments
Closed

Comments

@karthiknadig
Copy link
Contributor

Currently workspace symbols are limited 20. This should be a setting that can be controlled via initialization options, with following interpretation:

  • 0 to mean disable limit.
  • >0 as the number of symbols to limit.
@pappasam
Copy link
Owner

pappasam commented Mar 2, 2021

@karthiknadig Any reason for the >0 versus 0? Does this match some universal interface?

Is there is no strong justification, I think I'll just take an integer and interpret anything less than or equal to 0 as disabling the limit.

@pappasam
Copy link
Owner

pappasam commented Mar 3, 2021

Released in 0.26.0

@pappasam pappasam closed this as completed Mar 3, 2021
@karthiknadig
Copy link
Contributor Author

Thanks for adding this :)

I think I'll just take an integer and interpret anything less than or equal to 0 as disabling the limit.

This works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants