Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Are there any plans to add a formatter feature? #9

Closed
yaegassy opened this issue May 7, 2021 · 3 comments
Closed

[Question] Are there any plans to add a formatter feature? #9

yaegassy opened this issue May 7, 2021 · 3 comments

Comments

@yaegassy
Copy link
Contributor

yaegassy commented May 7, 2021

I thought it would be useful to add a formatter feature to nginx-language-server.

As you may know, there is a python tool called nginxfmt.

How about the idea of running this command from the language server?

Of course, you can use diagnostic-language-server (coc-diagnostic) to configure it, but many people may find it useful to have the features integrated in the language server itself.

@pappasam
Copy link
Owner

@yaegassy good question! It's not on my short-term roadmap because I personally use my own plugin for formatting files: https://github.com/pappasam/vim-filetype-formatter

I support https://github.com/vasilevich/nginxbeautifier out of the box there. Happy to consider adding a formatter though because it's definitely in-scope for the project!

@pappasam
Copy link
Owner

Just tried nginx-config-formatter. Nice tool, I'd be fine adding that as a dependency and supporting code formatting with this language server.

@yaegassy
Copy link
Contributor Author

I just wanted to share an idea with you, so this issue is closed.

Thanks reply! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants