Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement workaround for paprikka/lana-cli#5 #6

Merged
merged 3 commits into from Apr 18, 2017

Conversation

MarkTiedemann
Copy link
Contributor

@MarkTiedemann MarkTiedemann commented Apr 12, 2017

This PR improves lana's Windows support and, thus, solves #5.

This PR also:

  • fixes 3 linting issues
  • fixes 1 test which failed on windows due to an incorrectly joined path.

@paprikka paprikka merged commit 9e08a46 into paprikka:master Apr 18, 2017
@paprikka
Copy link
Owner

Hey, sorry for a late reply - just came back from (offline) hols. Tested the PR on Win7, Win8 (VMs) and OSX (Sierra) - works like charm. Awesome work, thanks!

@github-actions
Copy link

github-actions bot commented Jan 3, 2021

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants