Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window decorations are not scaled #209

Open
libf-de opened this issue Jan 1, 2016 · 8 comments
Open

Window decorations are not scaled #209

libf-de opened this issue Jan 1, 2016 · 8 comments
Labels
Milestone

Comments

@libf-de
Copy link

libf-de commented Jan 1, 2016

When setting a display scale, the window decorations dont get scaled. Installed today in ArchBang (openbox) running in VirtualBox. See for details: https://youtu.be/lxT86m3zSFY
decoration_scale

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29518222-window-decorations-are-not-scaled?utm_campaign=plugin&utm_content=tracker%2F8658931&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F8658931&utm_medium=issues&utm_source=github).
@IdrissDimson
Copy link
Contributor

Interesting

@iBelieve
Copy link
Member

iBelieve commented Jan 1, 2016

Good catch with the decorations not scaling.

@iBelieve iBelieve added the bug label Jan 1, 2016
@iBelieve iBelieve added this to the Version 0.2 milestone Jan 1, 2016
@alexkreidler
Copy link
Contributor

Is this what they are supposed to look like, or is it a bug?
papyros-window-decorations-issue

@libf-de
Copy link
Author

libf-de commented Jan 1, 2016

Maybe it's only here, but as you can see in the video, the slider is not showing correctly.

@IdrissDimson
Copy link
Contributor

yeah in the video it was cut off

@alexkreidler
Copy link
Contributor

The slider was cut off while I tested as well

@alexkreidler
Copy link
Contributor

Just filed slider issue under papyros/settings-app#14

@alexkreidler
Copy link
Contributor

@ibeliever
Implementation:

  • Get the scale value into a variable in decorations/main.cpp
  • In main.cpp: Line 100, multiply 4th parameter by the scale variable
    This will scale height by the variable you specify, and the width is automaticaly calulated from the width of the window, so we don't need to multiply that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants