Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Symbols & Miscellaneous nodes don't scale with screen sizes. #49

Closed
siliconivan opened this issue Sep 27, 2020 · 2 comments
Closed

Symbols & Miscellaneous nodes don't scale with screen sizes. #49

siliconivan opened this issue Sep 27, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request HacktoberFest HacktoberFest Related Issue, lets get to hacking! High Priority High Priority issue that should be prioritized refactor

Comments

@siliconivan
Copy link
Member

Change Proposal

For Symbols & Miscellaneous nodes, the layout service should default to using Stack layouts. Along with the Stack we should keep track of the resizing option from the design files. Where the Symbol/Misc node is used, we should inject a transform to scale the node to the size needed.

Unclear/Experiments to be done

It is unclear if forcing a Stack is completely necessary. The first experiment should be around injecting the transform & detecting the resizing option.

Module and Current Solution

This solution will likely effect the way the layout service works down to generation.

Benefits of the Change

Better UI Scalability

@siliconivan siliconivan added enhancement New feature or request High Priority High Priority issue that should be prioritized refactor labels Sep 27, 2020
@x64Eddie x64Eddie self-assigned this Sep 27, 2020
@x64Eddie
Copy link
Member

Yeah, I think changing the layout service is unnecessary, we should be able to just use Transform.scale()
is the way to go. We would just have to grab the information on the screen where the symbol is going to be displayed, then scale the symbol relative to the screen. For example, in the screen in the screenshot, I simply just wrapped the symbol instance by Transform.scale() and scaled the symbol up.
examplesymbol

@Ihuds577 Ihuds577 added the HacktoberFest HacktoberFest Related Issue, lets get to hacking! label Oct 1, 2020
@Ihuds577 Ihuds577 added this to the HacktoberFest! milestone Oct 1, 2020
@siliconivan
Copy link
Member Author

Duplicate of #130, other changes were made relating to this on other issues as well. #130 should fix this though, otherwise we can reopen it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request HacktoberFest HacktoberFest Related Issue, lets get to hacking! High Priority High Priority issue that should be prioritized refactor
Projects
No open projects
Development

No branches or pull requests

3 participants