Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace secp256k1 with k256 crate #136

Closed
mattsse opened this issue Oct 25, 2022 · 1 comment
Closed

Replace secp256k1 with k256 crate #136

mattsse opened this issue Oct 25, 2022 · 1 comment
Labels
A-devp2p Related to the Ethereum P2P protocol C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 25, 2022

the p2p net code currently relies on secp256k crate since some parts are adapted from other codebases.

This should be replaced with k256 crate, see ethers-signers for example.
@onbjerg onbjerg added C-enhancement New feature or request A-devp2p Related to the Ethereum P2P protocol labels Oct 28, 2022
@mattsse
Copy link
Collaborator Author

mattsse commented Nov 6, 2022

ref RustCrypto/elliptic-curves#675

@mattsse mattsse mentioned this issue Nov 6, 2022
Closed
@mattsse mattsse closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-devp2p Related to the Ethereum P2P protocol C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use k256 crate paradigmxyz/reth
2 participants
@onbjerg @mattsse