Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change interface HeadersRequest's BlockId to BlockHashOrNumber #199

Closed
mattsse opened this issue Nov 14, 2022 · 0 comments · Fixed by #203
Closed

Change interface HeadersRequest's BlockId to BlockHashOrNumber #199

mattsse opened this issue Nov 14, 2022 · 0 comments · Fixed by #203
Labels
A-devp2p Related to the Ethereum P2P protocol

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 14, 2022 •
edited

currently HeadersRequest start field is of type BlockId, whereas the eth protocol requires BlockHashOrNumber.

We should consider unifying this to BlockHashOrNumber otherwise it will require an additional convert before the request is send to handle the Pending, Latest, Safe variants.

wdyt @rkrasiuk ?
@mattsse mattsse added the A-devp2p Related to the Ethereum P2P protocol label Nov 14, 2022
@mattsse mattsse mentioned this issue Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-devp2p Related to the Ethereum P2P protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move BlockHashOrNumber to primitives paradigmxyz/reth
1 participant
@mattsse