Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure block propagation in devp2p #209

Closed
mattsse opened this issue Nov 15, 2022 · 0 comments · Fixed by #215
Closed

Allow to configure block propagation in devp2p #209

mattsse opened this issue Nov 15, 2022 · 0 comments · Fixed by #215
Labels
A-devp2p Related to the Ethereum P2P protocol

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 15, 2022 •
edited

With POS, block propagation via devp2p is considered invalid: https://eips.ethereum.org/EIPS/eip-3675#devp2p

   looks good, although there is still no forkid for the merge yet afaik. for example geth drops block broadcasts when its [`merger.PoSFinalized()`](https://github.com/ethereum/go-ethereum/blob/ae42148093fdfd72749ff3dda2b986cef543510f/eth/handler_eth.go#L121) returns true. this is set by the [handler for `engine_forkchoiceUpdatedV1`](https://github.com/ethereum/go-ethereum/blob/ae42148093fdfd72749ff3dda2b986cef543510f/eth/catalyst/api.go#L251)

Originally posted by @Rjected in #205 (review)

ref merger.PoSFinalized()
@mattsse mattsse added the A-devp2p Related to the Ethereum P2P protocol label Nov 15, 2022
@mattsse mattsse mentioned this issue Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-devp2p Related to the Ethereum P2P protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(net): add NetworkMode to enforce POS rules paradigmxyz/reth
1 participant
@mattsse