Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mermaid diagrams are not rendered in reth crate docs #4430

Open
shekhirin opened this issue Aug 31, 2023 · 4 comments
Open

Mermaid diagrams are not rendered in reth crate docs #4430

shekhirin opened this issue Aug 31, 2023 · 4 comments
Assignees
@onbjerg
Labels
C-bug An unexpected or incorrect behavior C-docs An addition or correction to our documentation M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@shekhirin
Copy link
Collaborator

shekhirin commented Aug 31, 2023 •
edited
Loading

Describe the bug

Rendered:

Not rendered:
@shekhirin shekhirin added C-bug An unexpected or incorrect behavior C-docs An addition or correction to our documentation labels Aug 31, 2023
@mattsse
Copy link
Collaborator

mattsse commented Aug 31, 2023

checking

@mattsse mattsse mentioned this issue Aug 31, 2023
Merged
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Sep 22, 2023
@shekhirin shekhirin removed the S-stale This issue/PR is stale and will close with no further activity label Sep 22, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 14, 2023
@mattsse mattsse added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Oct 14, 2023
@mattsse
Copy link
Collaborator

mattsse commented Jan 5, 2024

okay, looks like this is an issue with rustdocs of reexports which simply don't include the mermaid stuff for some reason.

we could hide the reexports, but that's probably not what we want

@onbjerg onbjerg self-assigned this Apr 2, 2024
@onbjerg onbjerg mentioned this issue Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onbjerg onbjerg

Labels
C-bug An unexpected or incorrect behavior C-docs An addition or correction to our documentation M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shekhirin @onbjerg @mattsse