Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UnknownSafeOrFinalizedBlock error string lower case #8045

Closed
joshieDo opened this issue May 2, 2024 · 0 comments · Fixed by #8355
Closed

Make UnknownSafeOrFinalizedBlock error string lower case #8045

joshieDo opened this issue May 2, 2024 · 0 comments · Fixed by #8355
Labels
A-rpc Related to the RPC implementation S-blocked This cannot more forward until something else changes

Comments

@joshieDo
Copy link
Collaborator

joshieDo commented May 2, 2024

Describe the change

#7552 introduces a capital letter on an error message when querying reth for the finalized block

/// Thrown when querying for `finalized` or `safe` block before the merge transition is
/// finalized, <https://github.com/ethereum/execution-apis/blob/6d17705a875e52c26826124c2a8a15ed542aeca2/src/schemas/block.yaml#L109>
///
/// op-node uses case sensitive string comparison to parse this error:
/// <https://github.com/ethereum-optimism/optimism/blob/0913776869f6cb2c1218497463d7377cf4de16de/op-service/sources/l2_client.go#L105>
///
/// Temporary, until a version of <https://github.com/ethereum-optimism/optimism/pull/10071> is pushed through that doesn't require this to figure out the EL sync status.
#[error("Unknown block")]
UnknownSafeOrFinalizedBlock,

Reason being that op-node is case sensitive on parsing the error during EL sync mode initialization:
https://github.com/ethereum-optimism/optimism/blob/0913776869f6cb2c1218497463d7377cf4de16de/op-service/sources/l2_client.go#L105

This issue is blocked until that changes, or the EL sync intialization flow changes.

Additional context

No response

@joshieDo joshieDo added S-blocked This cannot more forward until something else changes A-consensus Related to the consensus engine A-rpc Related to the RPC implementation and removed A-consensus Related to the consensus engine labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation S-blocked This cannot more forward until something else changes
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant