Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

untangle reth-interfaces #8342

Closed
mattsse opened this issue May 22, 2024 · 0 comments · Fixed by #8486
Closed

untangle reth-interfaces #8342

mattsse opened this issue May 22, 2024 · 0 comments · Fixed by #8486
Assignees
Labels
C-debt A section of code is hard to understand or change

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 22, 2024

Describe the feature

the reth-interfaces is a bit of a mess rn because it pulls in a bunch of crates just for error types.

while we need a super error type and having one crate that re-exports a bunch of stuff is nice, this quickly becomes inconvenient if we want to minimize deps of modular crates.

For example the evm crate pulls in the interfaces crate for the BlockExecutionError that is defined in interfaces, but this crate also pulls in more stuff that results in limitations like

#8240

The simplest solution here is just crate stacking, adding more crates.

This can be done either via an -api, -common crate which separates commonly used types/high level interfaces from implementations.

we should start with the provider error because this is very low in the error stack.

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled C-debt A section of code is hard to understand or change and removed S-needs-triage This issue needs to be labelled labels May 22, 2024
@mattsse mattsse self-assigned this May 22, 2024
@emhane emhane removed the C-enhancement New feature or request label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A section of code is hard to understand or change
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants