-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
untangle reth-interfaces #8342
Labels
C-debt
A section of code is hard to understand or change
Comments
mattsse
added
C-enhancement
New feature or request
S-needs-triage
This issue needs to be labelled
C-debt
A section of code is hard to understand or change
and removed
S-needs-triage
This issue needs to be labelled
labels
May 22, 2024
This was referenced May 23, 2024
This was referenced May 27, 2024
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the feature
the reth-interfaces is a bit of a mess rn because it pulls in a bunch of crates just for error types.
while we need a super error type and having one crate that re-exports a bunch of stuff is nice, this quickly becomes inconvenient if we want to minimize deps of modular crates.
For example the evm crate pulls in the interfaces crate for the BlockExecutionError that is defined in interfaces, but this crate also pulls in more stuff that results in limitations like
#8240
The simplest solution here is just crate stacking, adding more crates.
This can be done either via an
-api
,-common
crate which separates commonly used types/high level interfaces from implementations.we should start with the provider error because this is very low in the error stack.
Additional context
No response
The text was updated successfully, but these errors were encountered: