Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-std support for in reth-storage-errors #8459

Closed
mattsse opened this issue May 29, 2024 · 1 comment · Fixed by #8790
Closed

Add no-std support for in reth-storage-errors #8459

mattsse opened this issue May 29, 2024 · 1 comment · Fixed by #8790
Assignees
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 29, 2024

Describe the feature

Ideally, we want to have a subset of crates with no_std supports (evm specifically)
we need to do some prep for this first by making some crates no_std first

TODO

  • add #![cfg_attr(not(feature = "std"), no_std)]
  • Add to cargo.toml
default = ["std"]
std = []
  • Fix errors by manually implementing std::error::Error instead of deriving and put it behind std feature

Best way to do this is cargo expand and modify the generated code

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels May 29, 2024
@JackG-eth
Copy link
Contributor

Happy to take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
2 participants