Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CanonStateNotification out of reth-provider crate #9610

Open
Tracked by #8158
shekhirin opened this issue Jul 18, 2024 · 0 comments · May be fixed by #9612
Open
Tracked by #8158

Move CanonStateNotification out of reth-provider crate #9610

shekhirin opened this issue Jul 18, 2024 · 0 comments · May be fixed by #9612
Assignees
Labels
A-db Related to the database C-debt A section of code is hard to understand or change

Comments

@shekhirin
Copy link
Collaborator

Describe the feature

Currently, compiling reth-exex-types for Wasm doesn't work because of a reth-exex-types -> reth-provider -> reth-nippy-jar -> phf -> bitm dependency.

error[E0080]: evaluation of constant value failed
  --> /Users/shekhirin/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bitm-0.4.2/src/rank_select/select.rs:12:38
   |
12 | pub const BITS_PER_L1_ENTRY: usize = 1<<32;
   |                                      ^^^^^ attempt to shift left by `32_i32`, which would overflow

   Compiling anyhow v1.0.86

We should move CanonStateNotification into a new reth-provider-types crate that will just import basic *-types crates.

Additional context

No response

@shekhirin shekhirin added C-debt A section of code is hard to understand or change A-db Related to the database labels Jul 18, 2024
@shekhirin shekhirin self-assigned this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-db Related to the database C-debt A section of code is hard to understand or change
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

1 participant