Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JS tracer to muxTracer #58

Open
ArtificialPB opened this issue Mar 8, 2024 · 3 comments
Open

Add support for JS tracer to muxTracer #58

ArtificialPB opened this issue Mar 8, 2024 · 3 comments

Comments

@ArtificialPB
Copy link
Contributor

Follow-up of #57, currently muxTracer supports only built-in tracers. It should also support JS tracers.

In the alloy-rs tracing crate, the MuxConfig and MuxFrame types will need to have map key changed to GethDebugTracerType. Changes in this project should be pretty much the same, with addition of supporting the JSInspector via DelegatingInspector. Changes in reth are probably not needed.

The JSInspector is under js-tracer feature, so a feature gate for it in MuxInspector will need to be added as well.

@mattsse
Copy link
Contributor

mattsse commented Mar 8, 2024

@ArtificialPB I'll need to bump evm-inspectors on reth shortly, so if you find the time I'd appreciate a pr that adds the missing ::Mux handler for debug_trace* etc:

https://github.com/paradigmxyz/reth/blob/e21304947b6a46ba524d4b1e68351b05587d8892/crates/rpc/rpc/src/debug.rs#L279-L279

https://github.com/paradigmxyz/reth/blob/e21304947b6a46ba524d4b1e68351b05587d8892/crates/rpc/rpc/src/debug.rs#L512-L512

@ArtificialPB
Copy link
Contributor Author

@mattsse yeah, just opened it about an hour ago: paradigmxyz/reth#7053

@mattsse
Copy link
Contributor

mattsse commented Mar 8, 2024

ah amazing!
ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants